Repository navigation
fix(validation): open signed PDF by UUID instead of the owner's nodeIdFixes #9103 - #9104
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
25f1d8c to
73d761e
Compare
Signed-off-by: oPeras1 <hugo.pereira@rnl.tecnico.ulisboa.pt>
73d761e to
5b09ae4
Compare
|
@oPeras1 I'll wait a bit before merge this PR because I found other points to fix. |
|
Np, thanks! |
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
|
/backport to stable33 |
|
/backport to stable34 |
|
/backport to stable35 |
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
|
Hi @oPeras1, your first pull request to LibreSign has been merged. 🎉 Your work is part of LibreSign now, and everyone who signs a document with it benefits from the time and knowledge you shared. Thank you. You are very welcome to contribute again. The good first issue list is a good place to look next, and you no longer have to wonder how the process works. If you have a few minutes and feel like it, we would love to hear how this went for you: https://ls.librecode.coop/index.php/645932?lang=en&source=github-first-merged-pr&repository=libresign. It is entirely optional; nothing is expected of you in return for contributing. Come say hello in the LibreSign community: https://t.me/LibreSign |
Resolves: #9103
📝 Summary
On the validation page, "Open file" / "View PDF" passed the file owner's original
nodeIdtoOCA.Viewerfor logged-in users. Viewer handlers that resolvefileidin the current user's filesystem (Euro-Office, ONLYOFFICE) then:{"error":"File not found"}for signers and other logged-in users.This PR makes the validation page always open the signed PDF by UUID (
/apps/libresign/p/pdf/<uuid>), as it already does for anonymous visitors.openDocumentnow only usesOCA.Viewerwhen anodeIdis explicitly given, so other callers (Files list, sidebar, ID docs, settings) are unchanged.The change is frontend only. The backend route already resolves the storage owner from the UUID and serves the signed file.
🧪 How to test
/apps/libresign/validation/<uuid>and click "Open file":Validation evidence
🎨 UI / Front-end changes
main. The Viewer picks its handler by MIME type, and some handlers need a node the user can access, so it can't be used safely here.EnvelopeValidation, "View PDF" is shown when a file has auuid, instead of requiringnodeId.🚧 Tasks
✅ Checklist
🤖 AI (if applicable)